-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RI-112: [admin/companies] ajoute un composant de filtre au tableau des compagnies #168
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super boulot 👍 J'ai laissé quelques commentaires mais c'est vraiment top 🍾 .
Est-ce que tu pourrais ajouter plusieurs compagnies pour vérifier que la pagination fonctionne bien stp ?
D'autre part, c'est peut être préférable de lancer la recherche quand l'utilisateur appuie sur enter
parce que ça lance une requête à chaque caractère entré ... potentiellement ça peut faire bcp .... perso ça arrive à mon chat de s'assoir sur mon clavier ce qui me laisse parfois des messages de centaines de caractères 🤣 imagine le truc ...
🛑 Parce qu'il faut bien râler un p'tit peu de temps en temps, fais gaffe aux noms de tes PR (déjà on est sur des compagnies et pas des jobs ...) et en suite la règle c'est : RI-*: [module/sous-module] verbe d'action conjugué + détails
et pareil pour les commits/merge
...implicaction/src/app/admin/companies/components/companies-table/companies-table.component.ts
Outdated
Show resolved
Hide resolved
...implicaction/src/app/admin/companies/components/companies-table/companies-table.component.ts
Outdated
Show resolved
Hide resolved
...nd-implicaction/src/app/admin/jobs/components/job-posting-form/job-posting-form.component.ts
Show resolved
Hide resolved
frontend-implicaction/src/app/company/enums/company-sort.enum.ts
Outdated
Show resolved
Hide resolved
frontend-implicaction/src/app/company/enums/company-sort.enum.ts
Outdated
Show resolved
Hide resolved
...src/main/java/com/dynonuggets/refonteimplicaction/repository/impl/CompanyRepositoryImpl.java
Outdated
Show resolved
Hide resolved
...d-implicaction/src/main/java/com/dynonuggets/refonteimplicaction/service/CompanyService.java
Outdated
Show resolved
Hide resolved
...implicaction/src/app/admin/companies/components/companies-table/companies-table.component.ts
Outdated
Show resolved
Hide resolved
frontend-implicaction/src/app/core/services/api-endpoints.service.ts
Outdated
Show resolved
Hide resolved
frontend-implicaction/src/app/core/services/api-endpoints.service.ts
Outdated
Show resolved
Hide resolved
frontend-implicaction/src/app/shared/components/company-filter/company-filter.component.html
Outdated
Show resolved
Hide resolved
frontend-implicaction/src/app/job/models/company-criteria-filter.ts
Outdated
Show resolved
Hide resolved
...icaction/src/main/java/com/dynonuggets/refonteimplicaction/controller/CompanyController.java
Outdated
Show resolved
Hide resolved
e8c90aa
to
7d0823a
Compare
import {EnumCodeLabelAbstract} from '../../shared/enums/enum-code-label-abstract.enum'; | ||
import {SortDirectionEnum} from '../../shared/enums/sort-direction.enum'; | ||
|
||
export enum CompanySortEnumCode { | ||
NAME_ASC = 'NAME_ASC', | ||
NAME_DESC = 'NAME_DESC' | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ce fichier ne me semble pas utilisé. A vérifier et si c'est le cas 🧹
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Il est utilisé pour le tri par nom de compagnie au niveau du CompaniesTableComponent :)
frontend-implicaction/src/app/shared/components/job-filter/job-filter.component.html
Outdated
Show resolved
Hide resolved
* problème de pagination * problème au niveau des tests
* ajout du test controller
* récupération et envoi des paramètres de l'url
* correction linter
* correction linter
…compagnies * code review
…compagnies * code review
this.companyContextService | ||
this.pageable.sortOrder = CompanySortEnum.NAME_ASC.sortDirection; | ||
this.pageable.sortBy = CompanySortEnum.NAME_ASC.sortBy; | ||
this.selectedOrderCode = CompanySortEnum.NAME_ASC.code; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je vois bien que la valeur est affectée ici, mais aussi qu'elle ne sert à rien d'autre.
-- update
problème de pagination